Run tests on .NET 8.0 #2039
Merged
Run tests on .NET 8.0 #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test needed to be lightly modified because the way in which it was trying to test what it wanted to test doesn't quite work in .NET 8.0.
mwadams
approved these changes
Nov 15, 2023
HowardvanRooijen
approved these changes
Nov 15, 2023
|
@mwadams wrote:
It's certainly not supposed to! I had a quick look through the PR to double check, and as far as I can tell this just adds .NET 8.0 in the test projects. I was planning to remove .NET 7.0 from the tests once .NET 7.0 goes out of support, but not before. |
idg10
added a commit
that referenced
this pull request
May 21, 2024
* Run tests on .NET 8.0 * Add .NET 8.0 installation to build pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
net8.0andnet8.0-windows10.0.19041targets to test project.Modified
Directory.build.targetsto recognize .NET 8.0 targets.One test needed to be lightly modified because the way in which it was trying to test what it wanted to test doesn't quite work in .NET 8.0.